Handle integer replies, implement a connect timeout and dynamic config in VCL #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Because the VCC specifies PRIV_CALL for vmod_send() and vmod_call(), the vmod_priv argument is NULL for every call to these functions. This causes the config struct to be re-allocated for every call. This patch changes PRIV_CALL to PRIV_VCL, making the vmod_priv argument shared between all calls to the module's functions within a given instance of a VCL. The allocation of the config struct is also moved from redis_common() to init_function(). Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Use redisConnectWithTimeout() instead of redisConnect() to prevent hanging for minutes when the host is down (i.e, not responding). The default timeout is set to 200ms via REDIS_TIMEOUT_MS in vmod_redis.c. Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
…dis()
By default libvmod-redis attempts to connect to the Redis server
at 127.0.0.1, port 6379 with a connect timeout of 200 ms.
This patch allows the Redis hostname, port and timeout to be configured
via VCL using redis.init_redis(hostname, port, timeout_ms);
VCL example:
import redis;
sub vcl_init {
redis.init_redis("localhost", 6379, 200);
}
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
…mple.vcl Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
Signed-off-by: Noah Williamsson <noah.williamsson@gmail.com>
|
Awesome, thanks! |
andreacampi
pushed a commit
that referenced
this pull request
May 31, 2012
Handle integer replies, implement a connect timeout and dynamic config in VCL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please consider pulling the following patches (details available in the commit messages):
Noah Williamsson (6):
Handle REDIS_REPLY_INTEGER in vmod_call() and return it as a string
Initialize config (host, port) once per VCL instead of once every call
Implement a connect timeout for connecting to Redis, defaulting to 200ms
Allow the Redis server and timeout to be set in VCL via redis.init_redis()
Provide a commented out example of redis.init_redis() in examples/example.vcl
Fix typo in examples/example.vcl (redis.call -> redis.send)
Tested on 32- and 64-bit Linux aswell as Mac OS X with Varnish 3.0.2.